-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed and extended #43
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work on core integration. Shipped with cperl under cpan/Yaml-LibYAML with stricter C warnings and no blib.
from yaml/libyaml#7 and some added perl_libyaml.c fixes
which is fatal with -m32
Change the default indent behavior of map elements, advance the indent the children of the map according to the spec: 6.1 Indentation Spaces: "Each node must be indented further than its parent node. All sibling nodes must use the exact same indentation level. However the content of each sibling node may be further indented independently." http://yaml.org/spec/1.2/spec.html#id2777534 and make it readable by YAML, and behave the same as all other YAML writers. Fallback to the old YAML::XS map indent by setting the global $YAML::XS::IndentlessMap to a true value. Fixes RT #41463 and starts making it usable as default YAML library for core.
Add native DumpFile, LoadFile support filename in error messages. Add dumper options: Indent, BestWidth, Canonical, Unicode, Encoding, LineBreak, OpenEnded (kept defaults) Add loader option: NonStrict, Encoding (kept defaults) Fix default emitter_set_width (2 => 80) Fix the tests for the new default IndentlessMap=0 and check also IndentlessMap=1 enable 2 more test/glob.t tests fix dump_yaml in test/TestYAMLTests.pm upstream: add problem_nonstrict to parser add DEBUG macros to emitter.c, fix some indentations
ff72acd
to
60d94db
Compare
Use error codes, return undef on error. abstract the loader functionality to load_impl(), dump_impl() not yet. rearrange static funcs (not decl in header) LoadFile is now XS only bump the libyaml library version to 0.1.7
Accept IO, magic strings or fileglob argument types for (Load|Dump)File All test pass.
👍 |
put goto and return into extra lines, to be able to set breakpoints. fix a couple of extreme compiler warnings i.e. clang -Weverything. shadowing variable names, unused code.
rurban
pushed a commit
to perl11/cperl
that referenced
this pull request
Mar 18, 2016
Perl CPAN silently allows any unknown escape chars to pass them to regexp. Mimic that in nonstrict mode. Add a cpan test.
we cannot malloc to an anon struct in C++. typedef yaml_anchors_t Improve Makefile.PL for duplicate LibYAML.c
avoid duplicate checks against NULL
Update Changes
See PR #50 cperl 0.74 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*.c fixes from Fixed most compiler warnings -Wall -Wextra yaml/libyaml#7
and some added perl_libyaml.c fixes
support filename in error messages.
Encoding, LineBreak, OpenEnded (kept defaults)
YAML is now able to read YAML::XS written files,
and YAML::XS written files have now the same map indent as all other YAML writers.
The new optional NotStrict loader option added also
The relevant libyaml changes are in yaml/libyaml#8