Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update All.swim #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update All.swim #117

wants to merge 1 commit into from

Conversation

vadrer
Copy link

@vadrer vadrer commented Jun 6, 2021

a correction - $_->size looks incorrect

a correction - `$_->size` looks incorrect
@coveralls
Copy link

coveralls commented Jun 6, 2021

Coverage Status

Coverage increased (+0.1%) to 90.255% when pulling 1ab18b0 on vadrer:patch-1 into 2c8ab8f on ingydotnet:master.

@sesc
Copy link
Contributor

sesc commented Jun 6, 2021

And yet it is correct and your untested change unfortunately is the incorrect one. The callback you specify is not called with each element as an argument $cb->($el);, but with it as a localized default variable, as in grep() and map(): { local $_ = $el; $cb->(); }.

@vadrer
Copy link
Author

vadrer commented Jun 6, 2021

ok, thank you for the correction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants