Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix and reword for scrolling feature #113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Akeboshiwind
Copy link

Does two things:

  • Adjusts the wording in the README to better reflect current code
  • Fix a bug where pages don't scroll if there's no ajax request made

It does this by changing :route-counter to be just a pure number and not keep track of the route.
Now:

  • ::poll checks against the :kee-frame/route which is updated before ::poll is called
  • Ajax interceptors are only setup once (a small efficiency gain)
  • monitor-requests! is part of the cond-> in ::route-changed which seems a bit cleaner

I've tested that this works against this repo I created: https://github.com/ake-temp/kee-frame-scroll-repro

@egg-juxt egg-juxt deleted the fix-scroll branch March 6, 2024 16:30
@egg-juxt egg-juxt restored the fix-scroll branch March 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants