Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:base-path option to allow deployment on non-root paths #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grmble
Copy link

@grmble grmble commented Oct 28, 2022

I would like to be able to deploy kee-frame applications on github project pages which typically look like yourname.github.io/your-project. This does not work at all unless you disable route hashing. But then your application will only work as long as you start it by going to the root route. If you reload the page while on a route not backed by an actual page you get an error.

Another option would be to have reitit do all the work. There is a :path option and a :use-fragment option, but I did not actually try this. https://cljdoc.org/d/metosin/reitit/0.5.18/doc/frontend/browser-integration

fixes #109

works with and without hashed urls
@ingesolvoll
Copy link
Owner

@grmble Thanks a lot for this fix! Since I'm not actively working on kee-frame these days, I'm going to ask you to help me verify this. I'm guessing you are using a git dependency or a fork to use these changes yourself? Would you say the change is working in a stable way, and it's safe to include in the general library? If yes, I'll merge this and see if I can remember the release procedure 😄

@ingesolvoll
Copy link
Owner

Also, sorry for leaving you hanging on this, @grmble . Hope you found a way to use this without a release.

@grmble
Copy link
Author

grmble commented Mar 5, 2023

@ingesolvoll I am simply using my fork in deps.edn, lack of release is not a problem for me.

I do think the change works in a stable way, but I am only using it in a hobby project with an audience of 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash Routing on subdirectory not working
2 participants