Skip to content

LionInputFile: Customize the text content of the selected files for screen reader if uploadOnSelect is enabled #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vskorohod
Copy link

@vskorohod vskorohod commented Apr 17, 2025

Issue

If customer set uploadOnSelect to true,
screen reader indicates already uploaded files as selected for uploading.
Tested with VoiceOver on Mac:
image

image image image

What I did

  1. Update Lion Input File component.
  2. Provide correct translations based on the uploadOnSelect status.
  3. If uploadOnSelect set to true => use "fileUploaded" translations.
  4. If uploadOnSelect set to false => use "filesSelected" translations.

Copy link

changeset-bot bot commented Apr 17, 2025

🦋 Changeset detected

Latest commit: aa799dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vladimir Skorokhod seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants