Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild obj files on %.h changes #38

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

vyzigold
Copy link
Contributor

This will make it easier to test changes in .h files.

Copy link
Contributor

@csibbitt csibbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, this was bothering me today :)

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/522c5a9110354004ae94f998e725208c

✔️ stf-crc-ocp_412-local_build SUCCESS in 37m 23s
✔️ stf-crc-ocp_414-local_build SUCCESS in 41m 01s
stf-crc-ocp_412-local_build-index_deploy FAILURE in 25m 05s
✔️ stf-crc-ocp_414-local_build-index_deploy SUCCESS in 50m 27s

Copy link
Contributor

@vkmc vkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkmc
Copy link
Contributor

vkmc commented May 30, 2024

Most of the jobs are passing and the one that is not is because of lack of resources, so I think we are fine to merge this one. Thanks!

@vkmc vkmc merged commit 85b865d into master May 30, 2024
2 of 3 checks passed
@vkmc vkmc deleted the jwysogla_rebuilt_on_h_changes branch May 30, 2024 07:55
vkmc added a commit that referenced this pull request Aug 26, 2024
* [zuul] Add zuul jobs to sg-bridge (#33)

Depends-On: http://github.com/infrawatch/service-telemetry-operator/pull/512

* [zuul] Use the stf-crc-jobs project template (#34)

Instead of updating the .zuul.yaml file everytime
infrawatch/service-telemetry-operator adds a new job, the
project-template can be updated in STO, which will propogate
the change to the project and avoid leaving gaps in testing.

Depends-On: infrawatch/service-telemetry-operator#514

* Bump actions checkout to v4 (#36)

Bump actions checkout to v4 since Node.js 16 actions are deprecated.
We need to update to Node.js 20, which is included in actions/checkout@v4.

* Rebuild obj files on %.h changes (#38)

* Add IPv6 support (#37)

* Add IPv6 support

This patch makes bridge accept IPv6 addresses as amqp_url value.

* Committing clang-format changes

* Eliminate implicit-function-declaration in tests

* Correct character class in AMQP_URL_REGEX

---------

Co-authored-by: InfraWatch CI <[email protected]>
Co-authored-by: Chris Sibbitt <[email protected]>
Co-authored-by: Victoria Martinez de la Cruz <[email protected]>

* Update repo info for opstools (#39)

Centos8s went EOL on 31.05.2024 so the packages have been moved to
centos vault mirror the repo config we use needs to be updated

---------

Co-authored-by: Emma Foley <[email protected]>
Co-authored-by: Jaromír Wysoglad <[email protected]>
Co-authored-by: Martin Mágr <[email protected]>
Co-authored-by: InfraWatch CI <[email protected]>
Co-authored-by: Chris Sibbitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants