-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get tag from the name instead of the metadata #640
Conversation
Retrieve image tag from name instead of the image metadata when deploying from index with pre-built bundles.
The proposed change is expected to fail since in the upstream bundles we don't set the tag on the name, instead, we have the image tag on the metadata. We will need to consider that case separately (if Quay, do X). |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6fbdc4768e8b4c98a10efd0c25689448 ❌ stf-crc-ocp_414-local_build RETRY_LIMIT in 25m 03s |
Keep track of the tag being used for a bundle in the operator_bundle_tag var This is required when deploying from index + prebuilt bundles, since the tag of the bundle and the version in the metadata might differ
The STO/SGO image path needs a default when doing a local build. When deploying from index + prebuilt bundles we set this path when the bundles get imported. Add a conditional to avoid overwriting facts.
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7396a7439d6b403297750a5fc19d220a ❌ stf-crc-ocp_414-local_build RETRY_LIMIT in 24m 41s |
Retrieve image tag from name instead of the image metadata when deploying from index with pre-built bundles.
Create a new variable to keep the bundle tag information.
We need to keep track of both this values (bundle image tag and bundle image version) to properly construct the index image that will serve as basis for deploying STO and SGO