Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tag from the name instead of the metadata #640

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

vkmc
Copy link
Collaborator

@vkmc vkmc commented Nov 4, 2024

Retrieve image tag from name instead of the image metadata when deploying from index with pre-built bundles.

Create a new variable to keep the bundle tag information.

We need to keep track of both this values (bundle image tag and bundle image version) to properly construct the index image that will serve as basis for deploying STO and SGO

Retrieve image tag from name instead of the
image metadata when deploying from index with pre-built
bundles.
@vkmc vkmc added the do-not-merge Code is not ready to be merged label Nov 4, 2024
@vkmc
Copy link
Collaborator Author

vkmc commented Nov 4, 2024

The proposed change is expected to fail since in the upstream bundles we don't set the tag on the name, instead, we have the image tag on the metadata. We will need to consider that case separately (if Quay, do X).

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6fbdc4768e8b4c98a10efd0c25689448

stf-crc-ocp_414-local_build RETRY_LIMIT in 25m 03s
✔️ stf-crc-ocp_416-local_build SUCCESS in 35m 46s
stf-crc-ocp_414-local_build-index_deploy RETRY_LIMIT in 26m 34s
✔️ stf-crc-ocp_416-local_build-index_deploy SUCCESS in 42m 24s
stf-crc-ocp_414-nightly_bundles-index_deploy RETRY_LIMIT in 25m 31s
stf-crc-ocp_416-nightly_bundles-index_deploy FAILURE in 34m 57s

vkmc added 2 commits November 5, 2024 10:38
Keep track of the tag being used for a bundle
in the operator_bundle_tag var

This is required when deploying from index +
prebuilt bundles, since the tag of the bundle
and the version in the metadata might differ
The STO/SGO image path needs a default when doing
a local build. When deploying from index + prebuilt
bundles we set this path when the bundles get
imported.

Add a conditional to avoid overwriting facts.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7396a7439d6b403297750a5fc19d220a

stf-crc-ocp_414-local_build RETRY_LIMIT in 24m 41s
✔️ stf-crc-ocp_416-local_build SUCCESS in 36m 50s
stf-crc-ocp_414-local_build-index_deploy RETRY_LIMIT in 25m 52s
✔️ stf-crc-ocp_416-local_build-index_deploy SUCCESS in 37m 36s
stf-crc-ocp_414-nightly_bundles-index_deploy RETRY_LIMIT in 25m 40s
✔️ stf-crc-ocp_416-nightly_bundles-index_deploy SUCCESS in 30m 08s

@vkmc vkmc requested a review from compi-migui November 5, 2024 10:29
@vkmc vkmc removed the do-not-merge Code is not ready to be merged label Nov 5, 2024
@vkmc vkmc merged commit 804b49e into master Nov 5, 2024
9 of 10 checks passed
@vkmc vkmc deleted the STF-1855/use-tag-from-name branch November 5, 2024 10:30
vkmc added a commit that referenced this pull request Nov 5, 2024
Backport of #640

Downstream CVP uses the stable-1.5 branch and breaks without this.

(cherry picked from commit 804b49e)
vkmc added a commit that referenced this pull request Nov 5, 2024
#641)

Backport of #640

Downstream CVP uses the stable-1.5 branch and breaks without this.

(cherry picked from commit 804b49e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant