Add to irrelevant_files list #217

ayefimov-1 · 2025-01-28T23:36:04Z

Add to irrelevant_files list for graphing, logging and autoscaling jobs

and autoscaling jobs

softwarefactory-project-zuul · 2025-01-28T23:36:11Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 48, column 5
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 5

softwarefactory-project-zuul · 2025-01-29T13:45:12Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 7
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

softwarefactory-project-zuul · 2025-01-29T13:59:59Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 7
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

softwarefactory-project-zuul · 2025-01-29T14:09:53Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

mapping values are not allowed in this context
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 60, column 25

softwarefactory-project-zuul · 2025-01-29T14:15:49Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while constructing a mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 9
expected a mapping for merging, but found scalar
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 32, column 9

softwarefactory-project-zuul · 2025-01-29T15:09:09Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

expected a dictionary @ data['irrelevant-files'][0]

The problem appears in the the "functional-logging-tests-osp18" job stanza:

job:
name: functional-logging-tests-osp18
parent: telemetry-operator-multinode-logging
description: |
Run the logging functional tests on osp18
vars:
cifmw_extras:
- "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/ci-framework'].src_dir }}/scenarios/centos-9/multinode-ci.yml"
- "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/telemetry-operator'].src_dir }}/ci/vars-logging.yml"
...

in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 47

softwarefactory-project-zuul · 2025-01-29T15:19:16Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while constructing a mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 9
expected a mapping for merging, but found scalar
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 32, column 9

softwarefactory-project-zuul · 2025-01-29T15:28:50Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 7
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

softwarefactory-project-zuul · 2025-01-29T15:49:37Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while constructing a mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 9
expected a mapping for merging, but found scalar
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 32, column 9

softwarefactory-project-zuul · 2025-01-29T15:54:34Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

expected a dictionary @ data['irrelevant-files'][0]

The problem appears in the the "functional-logging-tests-osp18" job stanza:

job:
name: functional-logging-tests-osp18
parent: telemetry-operator-multinode-logging
description: |
Run the logging functional tests on osp18
vars:
cifmw_extras:
- "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/ci-framework'].src_dir }}/scenarios/centos-9/multinode-ci.yml"
- "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/telemetry-operator'].src_dir }}/ci/vars-logging.yml"
...

in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 47

softwarefactory-project-zuul · 2025-01-29T16:00:08Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 48, column 5
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

softwarefactory-project-zuul · 2025-01-29T16:23:53Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 48, column 5
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 7

softwarefactory-project-zuul · 2025-02-03T14:32:52Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 2, column 1
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 18, column 1

softwarefactory-project-zuul · 2025-02-03T14:39:01Z

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 49, column 5
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

and autoscaling jobs

elfiesmelfie · 2025-02-04T11:40:51Z

.zuul.yaml

@@ -58,7 +58,26 @@
    roles:
      - zuul: github.com/openstack-k8s-operators/ci-framework
    required-projects: *required_projects
-    irrelevant-files: *irrelevant_files
+    irrelevant-files:


This looks less than ideal. Can a combination of file and irrelevant-files be used?

Or perhaps a yaml anchor?
I looked at this article: https://medium.com/@kinghuang/docker-compose-anchors-aliases-extensions-a1e4105d70bd, I think something like this should work

irrelevant-files: &irrelevant_files - the - list - of - files ### some other content - irrelevant-files: - <<: *irrelevant_files - another - file

Tried the following with failure:

###################################### irrelevant-files: <<: *irrelevant_files - roles/telemetry_graphing - roles/telemetry_autoscaling - roles/telemetry_verify_metrics # (LINT FAILURE) ###################################### irrelevant-files: - <<: *irrelevant_files - roles/telemetry_graphing - roles/telemetry_autoscaling - roles/telemetry_verify_metrics # (Lint FAILURE) ###################################### irrelevant-files: - *irrelevant_files - roles/telemetry_graphing - roles/telemetry_autoscaling - roles/telemetry_verify_metrics # (Build failure) expected a dictionary @ data['irrelevant-files'][0] ####################################### irrelevant-files: *irrelevant_files - roles/telemetry_graphing - roles/telemetry_autoscaling - roles/telemetry_verify_metrics # ( LINT FAILURE ) ######################################## irrelevant-files: *irrelevant_files - roles/telemetry_graphing - roles/telemetry_autoscaling - roles/telemetry_verify_metrics # (Buuildset result ERROR) expected a dictionary @ data['irrelevant-files'][0]

Per rhos-prodchain-support:

dr.shimi :meow_puffy-terrified: [Yesterday at 18:45](https://redhat-internal.slack.com/archives/C0836QJNBF1/p1738626346118159?thread_ts=1738168284.356889&cid=C0836QJNBF1) so this is problem with YAML parsers... dr.shimi :meow_puffy-terrified: [Yesterday at 18:46](https://redhat-internal.slack.com/archives/C0836QJNBF1/p1738626367158379?thread_ts=1738168284.356889&cid=C0836QJNBF1) I cannot tell much, but AFAIK it works well with mappings/dictionaries, but not with lists dr.shimi :meow_puffy-terrified: [Yesterday at 18:46](https://redhat-internal.slack.com/archives/C0836QJNBF1/p1738626403827689?thread_ts=1738168284.356889&cid=C0836QJNBF1) I mean, the anchors stuff and extending the defintions dr.shimi :meow_puffy-terrified: [Yesterday at 18:47](https://redhat-internal.slack.com/archives/C0836QJNBF1/p1738626471739599?thread_ts=1738168284.356889&cid=C0836QJNBF1) you can sort of workaround it by defining it as dictionary in helper variable and then reusing that variable with list jinja filter, but that's ugly... dr.shimi :meow_puffy-terrified: [Yesterday at 18:48](https://redhat-internal.slack.com/archives/C0836QJNBF1/p1738626492350889?thread_ts=1738168284.356889&cid=C0836QJNBF1) TL;DR no nice solution as far as I know

Boo! (not directed at anyone)
This is annoying, but since it works and the alternatives were unsuccessful, then it'll have to do.
Thank you for looking at this and testing the alternatives.

I think that the irrelevant-files should support matching on regular expressions. It could make the list look tidier, and prevent issues later when new roles get added

Please try that out if it's not a huge effort (perhaps as a follow-up PR once this is done)

Add to irrelevant_files list for graphing, logging

e846964

and autoscaling jobs

Add to irrelevant_files list for graphing, logging

4dbf191

and autoscaling jobs

ayefimov-1 force-pushed the alexy_graphing branch from 32f4202 to 4dbf191 Compare February 3, 2025 18:09

Merge branch 'master' into alexy_graphing

0057e98

elfiesmelfie reviewed Feb 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add to irrelevant_files list #217

Add to irrelevant_files list #217

ayefimov-1 commented Jan 28, 2025

softwarefactory-project-zuul bot commented Jan 28, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Feb 3, 2025

softwarefactory-project-zuul bot commented Feb 3, 2025

elfiesmelfie Feb 4, 2025

ayefimov-1 Feb 4, 2025 •

edited

Loading

ayefimov-1 Feb 4, 2025 •

edited

Loading

elfiesmelfie Feb 4, 2025

elfiesmelfie Feb 4, 2025

Add to irrelevant_files list #217

Are you sure you want to change the base?

Add to irrelevant_files list #217

Conversation

ayefimov-1 commented Jan 28, 2025

softwarefactory-project-zuul bot commented Jan 28, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

softwarefactory-project-zuul bot commented Feb 3, 2025

softwarefactory-project-zuul bot commented Feb 3, 2025

elfiesmelfie Feb 4, 2025

Choose a reason for hiding this comment

ayefimov-1 Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

ayefimov-1 Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

elfiesmelfie Feb 4, 2025

Choose a reason for hiding this comment

elfiesmelfie Feb 4, 2025

Choose a reason for hiding this comment

ayefimov-1 Feb 4, 2025 •

edited

Loading

ayefimov-1 Feb 4, 2025 •

edited

Loading