Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] Fix failure condition in file test #204

Merged
merged 3 commits into from
Jan 31, 2025
Merged

[common] Fix failure condition in file test #204

merged 3 commits into from
Jan 31, 2025

Conversation

elfiesmelfie
Copy link
Collaborator

@elfiesmelfie elfiesmelfie commented Jan 17, 2025 •
edited
Loading

failed_when uses and for list items, and fails only when all conditions are met

The task should fail when any of the conditions are met.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/54781ace22c64529a6d4d0feb3b0faff

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 06s
❌ functional-tests-on-osp18 FAILURE in 1h 52m 30s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 09m 31s
❌ functional-graphing-tests-osp18 FAILURE in 1h 07m 22s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 05m 16s

@elfiesmelfie elfiesmelfie mentioned this pull request Jan 23, 2025
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #211 is needed.

@elfiesmelfie elfiesmelfie force-pushed the efoley/common_fix_file_test branch from 67f0346 to 2e225ab Compare January 27, 2025 18:00
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e8e1826811904cd58dd4a5fd8d1ebe8d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 50s
❌ functional-tests-on-osp18 FAILURE in 1h 48m 07s
❌ functional-logging-tests-osp18 FAILURE in 1h 04m 16s
❌ functional-graphing-tests-osp18 FAILURE in 1h 03m 20s (non-voting)
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 05m 49s

@elfiesmelfie elfiesmelfie force-pushed the efoley/common_fix_file_test branch from 2e225ab to 6983721 Compare January 29, 2025 12:14
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/760da7cc0288434390769ce44e4f44e3

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 00m 13s
❌ functional-tests-on-osp18 FAILURE in 1h 47m 41s (non-voting)
❌ functional-logging-tests-osp18 FAILURE in 1h 02m 11s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 02m 34s (non-voting)
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 04m 44s

@elfiesmelfie elfiesmelfie mentioned this pull request Jan 29, 2025
Open
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8269b1fa1dad485aba73266c0dc9317b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 48s
✔️ functional-tests-on-osp18 SUCCESS in 1h 18m 19s
❌ functional-logging-tests-osp18 POST_FAILURE in 1h 03m 17s
❌ functional-graphing-tests-osp18 FAILURE in 1h 06m 05s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 06m 44s

@elfiesmelfie
Copy link
Collaborator Author

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8269b1fa1dad485aba73266c0dc9317b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 48s ✔️ functional-tests-on-osp18 SUCCESS in 1h 18m 19s ❌ functional-logging-tests-osp18 POST_FAILURE in 1h 03m 17s ❌ functional-graphing-tests-osp18 FAILURE in 1h 06m 05s ✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 06m 44s

The functional-tests-osp18 job failed because PR#218 was not merged. This should be resolved now.
The functional-logging-tests-osp18 failed because the file test ran on the controller; it should run on the compute, this is addressed in PR#206, which was pending CI results in order to merge. This should be resolved now.

@elfiesmelfie
[common] Fix failure condition in file test
549e401 
failed_when uses and for list items, and fails only when all conditions are met
@elfiesmelfie
[common][file] Use assert instead of failed_when
b2e621e 
This allows more information to be shown about why the test failed.
@elfiesmelfie elfiesmelfie force-pushed the efoley/common_fix_file_test branch from 3aceb6a to b2e621e Compare January 30, 2025 16:14
@mgirgisf mgirgisf merged commit c46a955 into master Jan 31, 2025
8 checks passed
@mgirgisf mgirgisf deleted the efoley/common_fix_file_test branch January 31, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgirgisf mgirgisf mgirgisf approved these changes

@vyzigold vyzigold vyzigold approved these changes

@lnatapov lnatapov Awaiting requested review from lnatapov

@myadla myadla Awaiting requested review from myadla

@ayefimov-1 ayefimov-1 Awaiting requested review from ayefimov-1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elfiesmelfie @vyzigold @mgirgisf