Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix functional tests failures for STF tests #166

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Fix functional tests failures for STF tests #166

wants to merge 11 commits into from

Conversation

elfiesmelfie
Copy link
Collaborator

@elfiesmelfie elfiesmelfie commented Oct 29, 2024 •
edited
Loading

The issue may have been caused by the observability strategy tests causing both community and redhat monitoring components to be installed and shadowing the monitoring component definitions (prom, alertmanager, etc)

Depends-On: #177

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 2 times, most recently from b8ffcb7 to ff8ef96 Compare October 31, 2024 18:57
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 3 times, most recently from 9f933df to 3fda2d0 Compare November 19, 2024 20:53
@elfiesmelfie
Copy link
Collaborator Author

recheck

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 6 times, most recently from 17863ff to 91990e9 Compare November 27, 2024 20:08
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 6 times, most recently from 8353e87 to 2503c4a Compare December 5, 2024 13:51
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,2503c4afab8eaa204bbd76b3b965a57f513aa587

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from 2503c4a to a381325 Compare December 5, 2024 17:52
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,a9a04c5158b0739624dadb794aa87b11cc5ac99b

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 4 times, most recently from de97212 to 2d46452 Compare December 10, 2024 18:41
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,119f7197dd557f8a5d286d7fb156f21bafc4e272

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,08ab06b0d20b820c0ec450c661ede3ba2f793bda

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 2 times, most recently from 410547e to 3190efb Compare December 17, 2024 18:07
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from 3190efb to a771ce8 Compare January 10, 2025 19:13
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from a771ce8 to 3190efb Compare January 14, 2025 15:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 166,3190efb09d875108c541e9b00c5d8261d6030205

@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from 3190efb to 50b970b Compare January 14, 2025 15:42
@elfiesmelfie elfiesmelfie mentioned this pull request Jan 23, 2025
Merged
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from 50b970b to d0efff0 Compare January 23, 2025 20:54
@elfiesmelfie
[test_snmp_traps] Remove grep and update failed_when
1104808
@elfiesmelfie
[test_snmp_traps] Undo update to stf object post-test
e1a42d6
@elfiesmelfie
[test_snmp_traps] Wait up to two minutes for the snmp logs to show th…
7c36550 
…e alarm
@elfiesmelfie
[test_alerts] Update alertmanager test
86e903a
@elfiesmelfie
Update test_alerts
1961a98 
* Update the alarm to use FVT_TESTING in the alarm description
  so we can identify the alarm created by this test
* Replace grep with an updated failed_when condition
* Correct the failed_when condition to match the alarm message
@elfiesmelfie
[test_alerts] Update pre- and post-test tasks
58ff671 
* Retry the check for alarm creation

TODO:
* Add check for Prometheus rule deletion
@elfiesmelfie
[test_alerts] Use command instead of shell
a6b9563 
Fix ansible-lint errors
@elfiesmelfie
[test_verify_email] Add quotes to the receiver name
c10bfff 
This avoids some errors in parsing the alertmanager config, which caused delays and the alarm not to appear in the logs
@elfiesmelfie
[test_alerts][test_snmp_traps] Add meaningful changed_when for `oc pa…
8f41d20 
…tch`
@elfiesmelfie
[temp][test_sensubility] Add more detail to the healthcheck
565eef9
elfiesmelfie
elfiesmelfie commented Jan 24, 2025
View reviewed changes
roles/test_snmp_traps/tasks/main.yml Outdated
Comment on lines 13 to 22
- name: "Set the prom auth"
ansible.builtin.include_role:
name: client_side_tests
tasks_from: get_prom_info.yml
vars:
prom_auth_method: token
when:
- prom_auth_string is not defined
- prom_url is not defined

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included in #209

roles/test_snmp_traps/tasks/main.yml
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file are included in #209 and in #212

@elfiesmelfie elfiesmelfie mentioned this pull request Jan 24, 2025
Open
@elfiesmelfie elfiesmelfie changed the title First pass at resolving the snmp test failures Fix functional tests failures for STF tests Jan 24, 2025
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch 3 times, most recently from 8a3889d to 695d95e Compare January 30, 2025 22:41
@elfiesmelfie elfiesmelfie force-pushed the fix_functional_test_failures branch from 695d95e to 214c79c Compare January 30, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elfiesmelfie