Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add vcsBaseCommitSha to estimate metadata #3059

Merged
merged 3 commits into from May 6, 2024

Conversation

vdmgolub
Copy link
Contributor

@vdmgolub vdmgolub commented May 2, 2024

It's empty on breakdown, and base branch's HEAD SHA on diff/output.
NB: When combining several JSONs in output command latest item's metadata will be used in the output.

@vdmgolub vdmgolub self-assigned this May 2, 2024
@vdmgolub vdmgolub force-pushed the feat/metadata-base-commit-sha branch from 47fcd03 to a7b72c4 Compare May 3, 2024 09:21
@vdmgolub vdmgolub marked this pull request as ready for review May 3, 2024 09:43
@vdmgolub vdmgolub requested review from hugorut and tim775 May 3, 2024 09:43
Copy link
Member

@tim775 tim775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update TestDiffWithCompareToFormatJSON and the other tests to show vcsBaseCommitSha being set properly.

@vdmgolub vdmgolub force-pushed the feat/metadata-base-commit-sha branch from 50b5441 to f5be293 Compare May 5, 2024 15:40
@vdmgolub vdmgolub requested a review from a team as a code owner May 5, 2024 16:12
@vdmgolub vdmgolub force-pushed the feat/metadata-base-commit-sha branch from d6f4e57 to d74330a Compare May 5, 2024 16:20
It's empty on breakdown, and base branch's HEAD SHA on diff/output.
NB: When combining several JSONs in output command latest item's
metadata will be used in the output.
@vdmgolub vdmgolub force-pushed the feat/metadata-base-commit-sha branch from d74330a to 993bc47 Compare May 5, 2024 16:34
@vdmgolub vdmgolub merged commit 12aa5e9 into master May 6, 2024
8 of 10 checks passed
@vdmgolub vdmgolub deleted the feat/metadata-base-commit-sha branch May 6, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants