Bugfix/dtc lbdn #298
Open
Bugfix/dtc lbdn #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… detection when entries are removed
… in nios_dtc_lbdn module
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues in the DTC LBDN module by improving the handling and documentation for the auth_zones parameter. Key changes include:
- Updating the auth_zones parameter description and transformation logic to support both string and dictionary formats.
- Extending the compare_objects function in the API module to include auth_zones in list length comparisons.
- Adjusting sample playbook and README documentation to reflect the new auth_zones functionality.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/modules/nios_dtc_lbdn.py | Updated auth_zones parameter details and transformation logic for improved zone processing. |
| plugins/module_utils/api.py | Extended comparison logic to include auth_zones when comparing objects. |
| playbooks/create_dtc_lbdn.yml | Modified sample play to showcase dictionary format usage for auth_zones. |
| README.md | Enhanced module documentation to describe the new auth_zones formats and behavior. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…dditional apt packages for PyGObject
…nfoblox-ansible into BUGFIX/DTC_LBDN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.