Bugfix/second record with same name option 1#202
Open
lenseB wants to merge 5 commits intoinfobloxopen:masterfrom
Open
Bugfix/second record with same name option 1#202lenseB wants to merge 5 commits intoinfobloxopen:masterfrom
lenseB wants to merge 5 commits intoinfobloxopen:masterfrom
Conversation
Added changelog fragment (description in https://docs.ansible.com/ansible/latest/community/development_process.html#community-changelogs)
Added changelog fragmet (method described in https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to)
accidental "-"
for the case of using the "nios_host_record"-module: - when there is one hostrecord with the same name already, it should behave like there are already >=2 hostrecords. - therefore the if-statement needs to be adjusted thatthe else-statement in line 343 is not executed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am developing an Ansible Playbook automating IPAM.
While using the infoblox.nios_modules I noticed a weird behaviour. After creating a hostrecord with an IP-address x and a hostname, I executed the playbook again now with a different IP-address y and the same hostname. The secon hostrecord was placed in the IP-Adress y but also the first hostrecord was placed there. Also the extra attributes of the first hostrecord changed.
This was already described in #108
I fixed the problem in the commit 58cb936. This only fixes the problem if the if_obj_type is "NIOS_HOST_RECORD".
A general fix is going to be given in the PR: Bugfix/second record with same name option 2. I can not forsee if the general fix influences any other use case though.