Skip to content

Commit

Permalink
[FIX] changed called_once_with to assert_called_once_with for unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
JkhatriInfobox committed Jun 28, 2024
1 parent a4102ca commit b7e5de8
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions tests/unit/plugins/module_utils/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def test_wapi_change(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)

def test_wapi_change_false(self):
self.module.params = {'provider': None, 'state': 'present', 'name': 'default',
Expand All @@ -125,7 +125,7 @@ def test_wapi_change_false(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)

def test_wapi_extattrs_change(self):
self.module.params = {'provider': None, 'state': 'present', 'name': 'default',
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/plugins/modules/test_nios_a_record.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,4 @@ def test_nios_a_record_update_record_name(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)
2 changes: 1 addition & 1 deletion tests/unit/plugins/modules/test_nios_aaaa_record.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,4 @@ def test_nios_aaaa_record_update_record_name(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)
4 changes: 2 additions & 2 deletions tests/unit/plugins/modules/test_nios_host_record.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def test_nios_host_record_update_comment(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)

def test_nios_host_record_update_record_name(self):
self.module.params = {'provider': None, 'state': 'present', 'name': {'new_name': 'default', 'old_name': 'old_default'},
Expand All @@ -152,4 +152,4 @@ def test_nios_host_record_update_record_name(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)
4 changes: 2 additions & 2 deletions tests/unit/plugins/modules/test_nios_network_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def test_nios_network_view_update_comment(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)

def test_nios_network_view_update_name(self):
self.module.params = {'provider': None, 'state': 'present', 'name': 'default', 'old_name': 'old_default',
Expand All @@ -131,7 +131,7 @@ def test_nios_network_view_update_name(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)

def test_nios_network_view_remove(self):
self.module.params = {'provider': None, 'state': 'absent', 'name': 'ansible',
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/plugins/modules/test_nios_nsgroup.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,4 @@ def test_nios_nsgroup_update_comment(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)
4 changes: 2 additions & 2 deletions tests/unit/plugins/modules/test_nios_ptr_record.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_nios_ptr_record_update_comment(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)

def test_nios_ptr_record_update_record_ptrdname(self):
self.module.params = {'provider': None, 'state': 'present', 'ptrdname': 'ansible.test.org',
Expand Down Expand Up @@ -162,7 +162,7 @@ def test_nios_ptr_record_update_record_ptrdname(self):
res = wapi.run('testobject', test_spec)

self.assertTrue(res['changed'])
wapi.update_object.called_once_with(test_object)
wapi.update_object.assert_called_once_with(test_object)

def test_nios_ptr6_record_create(self):
self.module.params = {'provider': None, 'state': 'present', 'ptrdname': 'ansible6.test.com',
Expand Down

0 comments on commit b7e5de8

Please sign in to comment.