PTEUDO-1602: DBRoleClaim Tests Update #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apulariravichandran
requested review from
drewwells,
leandrorichardtoledo and
bfabricio
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| By("Creating the custom resource for the Kind DbRoleClaim in the new namespace") | ||
| dbroleclaimdiffnamespace := &persistancev1.DbRoleClaim{} |
There was a problem hiding this comment.
Let's use camelCase for vars in Go.
There was a problem hiding this comment.
updated
| By("Getting the DbRoleClaim resource created in the new namespace") | ||
| dbroleclaimdiffnamespace := &persistancev1.DbRoleClaim{} | ||
| err = k8sClient.Get(ctx, types.NamespacedName{Name: resourceName, Namespace: newNamespace}, dbroleclaimdiffnamespace) | ||
| fmt.Printf("Status of DbRoleClaim: %+v", dbroleclaimdiffnamespace.Status) |
There was a problem hiding this comment.
Instead of printing the value, you can check if the status is what we expect.
There was a problem hiding this comment.
updated
| err = k8sClient.Get(ctx, secretName, secret) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| fmt.Printf("Secret Name: %s, Secret Data: %s", secret.Name, secret.Data) |
There was a problem hiding this comment.
updated
Comment on lines
411
to
413
| if err == nil { | ||
| fmt.Println("Connection to the database successful") | ||
| } |
There was a problem hiding this comment.
I think we don't need to print this, you are already checking whether there is an error or not.
There was a problem hiding this comment.
updated
| if tableDescription.Valid { | ||
| description = tableDescription.String | ||
| } | ||
| fmt.Printf("Table: %s, Owner: %s, Size: %s, Description: %s", tableName, tableOwner, tableSize, description) |
There was a problem hiding this comment.
I think it is more secure to check instead of printing the values.
There was a problem hiding this comment.
updated
leandrorichardtoledo
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following new DbRoleClaim Tests , creating a roleclaim in new namespace for a Dbclaim existing in another namespace
Output of running test