DNS Host Support for Ansible in v2 #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unasra
reviewed
Jan 31, 2025
unasra
reviewed
Feb 3, 2025
…nsible into dns_host_cleanpr
unasra
reviewed
Feb 4, 2025
unasra
reviewed
Feb 5, 2025
| that: | ||
| - dns_host_info.objects | length == 1 | ||
| - dns_host_info.objects[0].id == dns_host.id | ||
|
|
There was a problem hiding this comment.
Task for retrieval via tag filters is missing !
There was a problem hiding this comment.
dns host tags support is greyed out on CSP, but from dns service page we can add tags to dns_host, but they are not retrievable.
when I tried from postman, we could not see the tags being part of the payload
mathewab
reviewed
Feb 5, 2025
Comment on lines
+45
to
+54
| tag_filters: | ||
| description: | ||
| - Filter dict to filter objects by tags | ||
| type: dict | ||
| required: false | ||
| tag_filter_query: | ||
| description: | ||
| - Filter query to filter objects by tags | ||
| type: str | ||
| required: false |
There was a problem hiding this comment.
I saw that you commented elsewhere that this doesn't work. it should be removed in that case
|
Overall LGTM. PR should have been recreated in the new repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.