Infra Host Support for Ansible V2 #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewab
reviewed
Dec 11, 2024
Comment on lines
+3
to
+6
| #TODO: add tests | ||
| # The following require additional plugins to be supported. | ||
| # - internal_secondaries | ||
| # - nsgs |
| pass # Handled by BloxoneAnsibleModule | ||
|
|
||
|
|
||
| class HostsModule(BloxoneAnsibleModule): |
There was a problem hiding this comment.
nit: should be HostModule? Also, i am thinking if it should be InfraHostModule, since we also have dns host, dhcp host, etc.
Suggested change
| class HostsModule(BloxoneAnsibleModule): | |
| class HostModule(BloxoneAnsibleModule): |
| tags: run | ||
| # Create an Ip Space | ||
| - name: "Create an IP space" | ||
| tags: run |
There was a problem hiding this comment.
why is this tag required?
| csp_url: "{{ csp_url }}" | ||
| api_key: "{{ api_key }}" | ||
| block: | ||
| # Create a random View name to avoid conflicts |
There was a problem hiding this comment.
Suggested change
| # Create a random View name to avoid conflicts | |
| # Create a random IP Space name to avoid conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.