Implemented IPAM Range #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unasra
reviewed
Dec 5, 2024
| @@ -0,0 +1,2 @@ | |||
| deprecated_features: | |||
| - b1_ipam_range - is deprecated in favor of `ipam_range`. | |||
There was a problem hiding this comment.
New line required at the end of file.
| b1_ipam_range: | ||
| deprecation: | ||
| removal_version: 3.0.0 | ||
| warning_text: Use infoblox.bloxone.ipam_range instead. |
There was a problem hiding this comment.
New line required at the end of file .
| space: "{{ ip_space.id }}" | ||
| disable_dhcp: "true" | ||
| tags: | ||
| location: "some where on earth" |
There was a problem hiding this comment.
Lets keep this standardized and use either location = site1 or location1
| @@ -14,6 +14,10 @@ | |||
| author: "Amit Mishra (@amishra), Sriram Kannan(@kannans)" | |||
| short_description: Configure the IPAM range on Infoblox BloxOne DDI | |||
| version_added: "1.0.1" | |||
| deprecated: | |||
| removed_in: "3.0.0" | |||
| why: "This module is being deprecated and will be removed in version 3.0.0." | |||
There was a problem hiding this comment.
Suggested change
| why: "This module is being deprecated and will be removed in version 3.0.0." | |
| why: "This module is being deprecated and will be removed in version 3.0.0. Use M(ipam_range) instead." |
| - range_info.objects | length == 1 | ||
| - range_info.objects[0].tags.location == tag_value | ||
|
|
||
| # Test case for creating a range with a name |
There was a problem hiding this comment.
As the name already provides what the task does , the comment is redundant.
| @@ -0,0 +1,283 @@ | |||
| --- | |||
There was a problem hiding this comment.
Missing UTs
- Inheritance Sources
- Updation of start and end of the range
| state: "absent" | ||
| ignore_errors: true | ||
|
|
||
| - name: "Delete IP Space" |
There was a problem hiding this comment.
Can we have a standardized cleanup file in setup_ip_space instead of this and call that from here ?
Something like :
- ansible.builtin.include_role:
name: "setup_ip_space"
tasks_from: "cleanup.yml"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented IPAM Range