Infra Join token Support for Bloxone Ansible v2 #47
Conversation
| if not resp.results: | ||
| resp.results = [] | ||
|
|
||
| # If result is REVOKED, remove it from the list |
There was a problem hiding this comment.
The LIST call returns the "REVOKED" tokens too . This operation has been added to eliminate the revoked tokens
There was a problem hiding this comment.
The UI shows it as well, maybe we don't have to explicitly filter them out here.
There was a problem hiding this comment.
If this is implemented , assertion for idempotency would fail ( see comment below )
unasra
changed the title
plugins/modules/infra_join_token.py
Outdated
| - absent | ||
| default: present | ||
| description: | ||
| description: "" |
There was a problem hiding this comment.
a lot of this description is empty.
plugins/modules/infra_join_token.py
Outdated
| """ # noqa: E501 | ||
|
|
||
| EXAMPLES = r""" | ||
| - name: Create a UI Join token |
There was a problem hiding this comment.
| - name: Create a UI Join token | |
| - name: Create a Join Token |
same for the below examples as well
There was a problem hiding this comment.
removed UI keyword from all instances except API Name
plugins/modules/infra_join_token.py
Outdated
| tags: | ||
| location: "my-location" | ||
|
|
||
| - name: Delete a UI Join token |
There was a problem hiding this comment.
I think it might be better to explicitly state, we are revoking the token, instead of deleting.
plugins/modules/infra_join_token.py
Outdated
| pass # Handled by BloxoneAnsibleModule | ||
|
|
||
|
|
||
| class UIJoinTokenModule(BloxoneAnsibleModule): |
There was a problem hiding this comment.
suggestion to keep the names matching the module name JoinToken or InfraJoinToken
| class UIJoinTokenModule(BloxoneAnsibleModule): | |
| class JoinTokenModule(BloxoneAnsibleModule): |
| if not resp.results: | ||
| resp.results = [] | ||
|
|
||
| # If result is REVOKED, remove it from the list |
There was a problem hiding this comment.
The UI shows it as well, maybe we don't have to explicitly filter them out here.
plugins/modules/infra_join_token.py
Outdated
| choices: | ||
| - present | ||
| - absent |
There was a problem hiding this comment.
Maybe the choices here should be present and revoked as deletion is not allowed for join tokens.
| register: join_token | ||
| - assert: | ||
| that: | ||
| - join_token is not changed |
There was a problem hiding this comment.
If we dont filter out the revoked coin tokens , even though the join token would be revoked this , specific assertion would fail as find() function is bound to return the join token and the variable join_token would be updated accordingly .
So should this assertion be removed ?
There was a problem hiding this comment.
The find function can return the same join token, which is fine. However a change should not be detected if the join token is found, and is already revoked. That logic needs to be checked.
No description provided.