DNS Auth NSG Support for Bloxone Ansible v2 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unasra
reviewed
Dec 2, 2024
plugins/modules/dns_auth_nsg_info.py
Outdated
| - Filter query to filter objects | ||
| type: str | ||
| required: false | ||
| inherit: |
There was a problem hiding this comment.
Is inheritance supported by Auth Nsg ?
There was a problem hiding this comment.
no, removed it
plugins/modules/dns_auth_nsg_info.py
Outdated
| id=dict(type="str", required=False), | ||
| filters=dict(type="dict", required=False), | ||
| filter_query=dict(type="str", required=False), | ||
| inherit=dict(type="str", required=False, choices=["full", "partial", "none"], default="full"), |
There was a problem hiding this comment.
Check for inheritance support !
There was a problem hiding this comment.
not supported, removed and tested the playbook
| #TODO: add tests | ||
| # The following require additional plugins to be supported. | ||
| # - internal_secondaries | ||
| # - nsgs |
There was a problem hiding this comment.
What other plugins are required for the Nsg test ?
There was a problem hiding this comment.
Nsg test case would just require the definition of a different NSG and no host
plugins/modules/dns_auth_nsg.py
Outdated
| def find(self): | ||
| if self.params["id"] is not None: | ||
| try: | ||
| resp = AuthNsgApi(self.client).read(self.params["id"], inherit="full") |
There was a problem hiding this comment.
remove inherit param from the file if not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.