-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.netflow): Ensure type consistency for sFlow's IP version field #16403
Conversation
inputs.netflow
: fix inconsistent IP version field in sFlow decoder #16402There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joseluisgonzalezca thanks for the fix! Could you please add an Important Changes
section to the CHANGELOG.md
file describing that the field-type changes when decoding raw frames!?
…out `ip_version` value
Sure! I have just submitted a commit with the required information. I've set the version to 1.33.2 because I have seen it in the milestones section. Feel free to reach me again if it's not correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joseluisgonzalezca I added some suggestion on the Changelog entry. Could you please also check the 80-column limit in that file!?!
…ut the breaking change Co-authored-by: Sven Rebhan <[email protected]>
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joseluisgonzalezca!
Summary
This PR resolves the inconsistency with
ip_version
field in netflow metrics when using the sFlow V5 decoder. Version is received as a number (4 or 6), which will be converted to "IPv4" or "IPv6" respectively. ExistingdecodeSflowIPVersion
function was not enough for this case so I have created a new one to handle the conversion.Checklist
Related issues
resolves #16402