Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common.opcua): Support LocalizedText Datatype #16195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Digitomation
Copy link

@Digitomation Digitomation commented Nov 16, 2024

Summary

This PR adds support for returning OPCUA LocalizedText values via the opc-ua input plugin. Prior to this PR, we silently drop those values.
This PR is heavily inspired by #12101

I've converted Localizedtext text parameter to string,

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16194

I'm not proficient in Go, but needed this to work, any help or guidelines to this PR are appreciated!

@Digitomation Digitomation changed the title Update input_client.go OPC UA doesn't support LocalizedText Datatype Nov 16, 2024
@Digitomation Digitomation changed the title OPC UA doesn't support LocalizedText Datatype fix:OPC UA doesn't support LocalizedText Datatype Nov 16, 2024
@DStrand1 DStrand1 changed the title fix:OPC UA doesn't support LocalizedText Datatype fix(common.opcua): Support LocalizedText Datatype Nov 18, 2024
@telegraf-tiger telegraf-tiger bot added area/opcua fix pr to fix corresponding bug labels Nov 18, 2024
@DStrand1 DStrand1 self-assigned this Nov 18, 2024
@DStrand1
Copy link
Member

@Digitomation Thanks for the PR! The code looks good, but are you able to add a test case to cover it? Thanks!

@srebhan srebhan added the waiting for response waiting for response from contributor label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/opcua fix pr to fix corresponding bug waiting for response waiting for response from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPC UA doesn't support LocalizedText Datatype.
3 participants