Skip to content

Enterprise multi-node recommendations and Python libraries update #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

MeelahMe
Copy link
Contributor

…ly deployments

Closes #6053

@MeelahMe MeelahMe requested review from Copilot, peterbarnett03 and jstirnaman and removed request for peterbarnett03 May 29, 2025 17:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines documentation for plugin development and deployment and updates the JS config for module resolution.

  • Overhauls Python dependency installation instructions with embedded environment guidance and CLI/Docker examples.
  • Introduces distributed cluster considerations, mapping plugin triggers to node roles and routing client traffic.
  • Simplifies jsconfig.json by removing node_modules from the paths mapping.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
content/shared/v3-core-plugins/_index.md Expanded and clarified docs for Python package installation and multi-node deployment
assets/jsconfig.json Removed ../node_modules/* from paths to streamline module resolution
Comments suppressed due to low confidence (2)

content/shared/v3-core-plugins/_index.md:564

  • This description refers to creating a Python virtual environment, but the embedded environment is managed by the Processing Engine. Update this line to clarify that influxdb3 install package places dependencies into the engine’s embedded environment.
This creates a Python virtual environment in your plugins directory with the specified packages installed.

assets/jsconfig.json:6

  • Removing "../node_modules/*" from the paths may prevent the IDE or build from resolving modules in node_modules. Verify this change doesn’t break local development or consider documenting the new resolution behavior.
*

| HTTP request | `path:` | Nodes that serve API traffic|

For example:
- Run write-ahead log (WAL) plugins on ingester nodes.
Copy link
Preview

Copilot AI May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The example mentions WAL plugins but the trigger types table lists only data write, scheduled, and HTTP request triggers. Consider aligning the example with the table or explaining how WAL plugins map to the data write category.

Copilot uses AI. Check for mistakes.

@MeelahMe MeelahMe marked this pull request as ready for review May 29, 2025 17:37
- Use the Docker variant if you're running InfluxDB in a containerized environment.

> [!Note]
> If you create a custom virtual environment, use the Python interpreter bundled with InfluxDB 3—not system Python.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> If you create a custom virtual environment, use the Python interpreter bundled with InfluxDB 3—not system Python.
> #### Use bundled Python for plugins
> When you start the server with the `--plugin-dir` option, InfluxDB 3 creates a Python virtual environment (`<PLUGIN_DIR>/venv`) for your plugins.
> If you need to create a custom virtual environment, use the Python interpreter bundled with InfluxDB 3—not the system Python.

> If you create a custom virtual environment, use the Python interpreter bundled with InfluxDB 3—not system Python.
> Creating a virtual environment with system Python (for example, using `python -m venv`) can lead to runtime errors and plugin failures.
>
>F or details, see the [Process Engine README](https://github.com/influxdata/influxdb/blob/main/README_processing_engine.md#official-builds)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>F or details, see the [Process Engine README](https://github.com/influxdata/influxdb/blob/main/README_processing_engine.md#official-builds)
>For more information, see the [processing engine README](https://github.com/influxdata/influxdb/blob/main/README_processing_engine.md#official-builds).

> Creating a virtual environment with system Python (for example, using `python -m venv`) can lead to runtime errors and plugin failures.
>
>F or details, see the [Process Engine README](https://github.com/influxdata/influxdb/blob/main/README_processing_engine.md#official-builds)
> for advanced setup instructions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> for advanced setup instructions.

- Use the CLI command when running InfluxDB directly on your system.
- Use the Docker variant if you're running InfluxDB in a containerized environment.

> [!Note]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> [!Note]
> [!Important]


> [!Note]
> If you create a custom virtual environment, use the Python interpreter bundled with InfluxDB 3—not system Python.
> Creating a virtual environment with system Python (for example, using `python -m venv`) can lead to runtime errors and plugin failures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Creating a virtual environment with system Python (for example, using `python -m venv`) can lead to runtime errors and plugin failures.
> Creating a virtual environment with the system Python (for example, using `python -m venv`) can lead to runtime errors and plugin failures.

> for advanced setup instructions.

{{% /code-placeholders %}}

This creates a Python virtual environment in your plugins directory with the specified packages installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This creates a Python virtual environment in your plugins directory with the specified packages installed.
InfluxDB creates a Python virtual environment in your plugins directory with the specified packages installed.


When configuring Grafana to connect to an InfluxDB 3 Enterprise instance:
#### Examples:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Examples:
#### Examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recommendation to Enterprise multi-node recommendations
2 participants