Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DF (patched) branch to Nov 20 #51

Closed
wants to merge 10 commits into from
Closed

Updated DF (patched) branch to Nov 20 #51

wants to merge 10 commits into from

Conversation

wiedld
Copy link
Collaborator

@wiedld wiedld commented Jan 6, 2025 •
edited
Loading

This takes us up to Nov-20 SHA a2811fc

It advances DF by adding these nov-11 to nov-20 commits: cadeb53...influxdata:arrow-datafusion:a2811fc85d469c879e3d4db6ceb3fa13fbf263be

Change in patches:

Patches from the previous DF branch, which are no longer needed:

  • Screenshot 2025-01-07 at 2 28 21 PM

Newly added patches:

  • this ecc04d4 commit on Nov-20 introduced bugs which were then fixed in 2 followup DF commits
    • Screenshot 2025-01-07 at 2 31 28 PM

Patches applied:

  • Patches already fixed in future upstream commits:

    • Dec-3: upstream commit from customer apache@86740bf
    • Dec-3: upstream commit 143ef97
      • this is a patch on the ecc04d4 Nov-20 commit
    • Nov-24: upstream commit 304f51d
      • this is a patch on the ecc04d4 Nov-20 commit
    • updates to datafusion-cli/Cargo.lock
    • clippy updates (we still have a few errors without the clippy patch)
    • SanityCheckPlan

  • Patches still not fixed:

  • Patches specific to our DF branch (no need for upstream fix):

    • we are keeping in the warn logging for the schema mismatch. (Upstream only returns error, or not, based on schema misalignment): our patch 69d6118

alamb and others added 7 commits January 6, 2025 13:32
@alamb @wiedld
Test + workaround for SanityCheck plan
ba41c03
@wiedld
test: update new test which is part of Nov 20th upgrade, because the …
83749bb 
…SanityCheck plan patch (to turn it off) makes the output result sort nondeterministic
@wiedld
fix: handle when the left side of the union has no fields (e.g. an em…
4951f68 
…pty projection)
@wiedld
chore: default=true for skip_physical_aggregate_schema_check, and add…
05612c8 
… warn logging
@wiedld
Revert "Account for constant equivalence properties in union, tests (a…
9c098a5 
…pache#12562)"

This reverts commit 577e4bb.
@2010YOUY01 @wiedld
Add generate_series() udtf (and introduce 'lazy' MemoryExec) (apach…
06b656c 
…e#13540)

* Add generate_series() udtf

* liscence

* fix examples

* clippy

* comments

* singleton udtf init

* StreamingMemoryExec -> LazyMemoryExec

* use RwLock

* test udf+udtf generate_series() in the same sql

* CI

* CI

* small fixes
@alamb @wiedld
chore: workaround new clippy failures by disabling them
ae6d572
@wiedld wiedld changed the title Patched nov 20 Updated DF (patched) branch to Nov 20 Jan 6, 2025
wiedld and others added 3 commits January 6, 2025 15:06
@wiedld
chore: update datafusion-cli cargo.lock versions to pass CI
892c715
@jayzhan211 @wiedld
set timezone for timestamp (apache#13535)
1003146 
Signed-off-by: Jay Zhan <[email protected]>
@jonathanc-n @alamb @wiedld
feat: Add GroupColumn Decimal128Array (apache#13564)
90c35ca 
* feat: Add GroupColumn `Decimal128Array

* fix clippy

* fix errors

* remove .with_data_type

* fix

* fmt

* remove adjust_output_array

* fix

* Add missing data type

---------

Co-authored-by: Andrew Lamb <[email protected]>
@wiedld
Copy link
Collaborator Author

wiedld commented Jan 13, 2025

Closed as no longer used.

@wiedld wiedld closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
catalog common core documentation Improvements or additions to documentation execution functions logical-expr optimizer physical-expr sql sqllogictest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wiedld @alamb @2010YOUY01 @jayzhan211 @jonathanc-n