Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating forms docs #355

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Updating forms docs #355

wants to merge 6 commits into from

Conversation

iruzevic
Copy link
Member

No description provided.

@iruzevic iruzevic marked this pull request as draft January 23, 2025 15:42
@iruzevic iruzevic self-assigned this Jan 23, 2025
@iruzevic iruzevic requested a review from a team January 27, 2025 08:44
@iruzevic iruzevic marked this pull request as ready for review January 27, 2025 08:44
dadadavorin
dadadavorin previously approved these changes Jan 28, 2025
Copy link
Contributor

@piqusy piqusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just two minor suggestions

Add additional items to the top bar menu under the Add-on parent.

```php
add_filter('es_forms_admin_top_bar_menu_items', 'getTopBarMenuItems', 10, 2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add_filter('es_forms_admin_top_bar_menu_items', 'getTopBarMenuItems', 10, 2);
\add_filter('es_forms_admin_top_bar_menu_items', 'getTopBarMenuItems', 10, 2);

You don't need to provide order for all countries, only the ones you want to change the order and the rest will be displayed in the default order.

```php
add_filter('es_forms_block_country_custom_order', 'getBlockCountryCustomOrder');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add_filter('es_forms_block_country_custom_order', 'getBlockCountryCustomOrder');
\add_filter('es_forms_block_country_custom_order', 'getBlockCountryCustomOrder');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants