Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boilerplate): upgrade to Expo SDK 51 #2683

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented May 10, 2024

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

  • Upgrades to SDK 51
  • Removes unnecessary Flipper disabling code since it's removed from Expo template
  • Updated relevant versions in README.md

@frankcalise frankcalise marked this pull request as ready for review May 10, 2024 14:54
@frdteknikelektro
Copy link

Go!

@@ -2,8 +2,6 @@
const plugins = [
/** react-native-reanimated web support @see https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation/#web */
"@babel/plugin-proposal-export-namespace-from",
/** NOTE: This must be last in the plugins @see https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation/#babel-plugin */
"react-native-reanimated/plugin",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Frank, thanks for your great work on Ignite, as always!
Is the reanimated babel plugin not necessary anymore since Expo 51?
I stilll see it mentioned at the reanimated docs. https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/getting-started/#step-2-add-reanimateds-babel-plugin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no longer necessary since Expo 50. It's already included in babel-expo-preset

https://docs.expo.dev/develop/user-interface/animation/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants