Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Theming): Adds theming support with documentation. #2636

Open
wants to merge 25 commits into
base: v10
Choose a base branch
from
Open

feat(Theming): Adds theming support with documentation. #2636

wants to merge 25 commits into from
+1,577 −865

Conversation

markrickert
Copy link
Member

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

This PR adds theming support to the ignite boilerplate as well as relevant documentation on how to use the theming system.

Note that this PR is onto the v10 branch and not main.

@markrickert markrickert mentioned this pull request Feb 13, 2024
Open
@jamonholmgren
Copy link
Member

Before we merge this, I want to make sure we get some real-world experience. @markrickert you're starting a new project soon, so this will be a good opportunity for that.

jamonholmgren
jamonholmgren reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really looking good. Just want to wait for real-world experience.

docs/boilerplate/app/theme/Theming.md Outdated Show resolved Hide resolved
docs/boilerplate/app/theme/Theming.md Outdated Show resolved Hide resolved
docs/boilerplate/app/theme/Theming.md Outdated Show resolved Hide resolved
@markrickert
Copy link
Member Author

@jamonholmgren Absolutely. I'll keep this branch up to date with main and use this as the starting point for my next project.

@markrickert markrickert added this to the Ignite v10 milestone May 13, 2024
markrickert and others added 16 commits May 13, 2024 11:40
@markrickert
Initial shot at theming
c4bf8b5
@markrickert
Update theming context to include spacing, typography, and timing
c60d1ca
@markrickert
Fix some typescript issues.
cc778c0
@markrickert
Refine the types that themed takes as parameters for better typing
c2ddcab
@markrickert
Better usage of theme objects
c1c8ef8
@markrickert
Fix issues with using themed spacing and colors directly in the hook
19b269f
@markrickert
chore(docs): Update documentation for theming system.
0deaf99
@markrickert
Linter fixes
8ae9de8
@markrickert
Fix the component generator
02e5d88
@markrickert
Remove useThemeProvider console.log
defd725
@markrickert @jamonholmgren
Update docs/boilerplate/app/theme/Theming.md
58abb6f 
Co-authored-by: Jamon Holmgren <[email protected]>
@markrickert @jamonholmgren
Update docs/boilerplate/app/theme/Theming.md
cda152b 
Co-authored-by: Jamon Holmgren <[email protected]>
@markrickert @jamonholmgren
Update docs/boilerplate/app/theme/Theming.md
779f70d 
Co-authored-by: Jamon Holmgren <[email protected]>
@markrickert
Fix issue with removing demo code where theming things were incorrect…
924c416 
…ly removed.
@markrickert
Fix theming bug in Button component.
a405bc2
@markrickert
Add expo configuration to be able to switch themes.
9120653
markrickert and others added 9 commits May 13, 2024 11:43
@markrickert
Fix the DemoDebugScreen theme toggling components.
3d19a44
@HalfAkilo @markrickert
fix(boilerplate): doc url (#2658 by @HalfAkilo)
0d8b09e 
[skip ci]
@frankcalise @markrickert
docs(api): fix backend integration link (#2662 by @frankcalise)
d7a3220 
[skip ci]
@jamonholmgren @markrickert
chore(docs): Clean up README getting started a bit (#2664 by @jamonho…
2c1c56b 
…lmgren)

Helps address #2663.  [skip ci]
@Parrryy @markrickert
fix(cli): add prebuild:clean to splash screen gen output (#2665 by @P…
3c40dc4 
…arrryy)

Co-authored-by: Chris Parry <[email protected]>
@semantic-release-bot @markrickert
chore(release): 9.6.3 [skip ci]
3ff06d5 
## [9.6.3](v9.6.2...v9.6.3) (2024-04-14)

### Bug Fixes

* **boilerplate:** doc url ([#2658](#2658) by @HalfAkilo) ([7111bf7](7111bf7))
* **cli:** add prebuild:clean to splash screen gen output ([#2665](#2665) by @Parrryy) ([725c4e5](725c4e5))
@81reap @markrickert
Fixes typo (#2669)
d79b11f
@iaurg @markrickert
docs: update link to useSafeAreaInsetsStyle docs (#2676 by @iaurg)
fe376e1 
[skip ci]
@markrickert
Fixes issues after the changing around of toggles and switches.
06beb2c
@markrickert
Copy link
Member Author

Rebased on the v10 branch and fixed a few issues caused by the Switch/Toggle rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankcalise frankcalise frankcalise left review comments

@jamonholmgren jamonholmgren jamonholmgren left review comments

@Jpoliachik Jpoliachik Jpoliachik left review comments

@mazenchami mazenchami Awaiting requested review from mazenchami

@joshuayoes joshuayoes Awaiting requested review from joshuayoes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ignite v10
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@markrickert @jamonholmgren @frankcalise @Jpoliachik @HalfAkilo @Parrryy @semantic-release-bot @81reap @iaurg