Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #33 fix source test results saving #34

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

il-dat
Copy link
Collaborator

@il-dat il-dat commented Oct 8, 2024

resolves #33

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

  • Fix: The sources' test results can not be saved due to that the Relation object is returned as 'str' unexpectedly
  • New: Adapt dbt v1.8

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@il-dat
Copy link
Collaborator Author

il-dat commented Oct 8, 2024

To fix CI later, locally checks all good ✅

@il-dat il-dat merged commit a024f21 into main Oct 8, 2024
0 of 2 checks passed
@il-dat il-dat deleted the bugfix/33-fix-cannot-save-test-for-sources branch October 8, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error storing test results in BigQuery - 'str' object has no attribute 'database'
1 participant