Upgrade to Infinispan 13.0 and Cassandra Java Driver 4.14 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschlosser
force-pushed
the
main
branch
from
2a55f31 to
b2f8a5c
Compare
dominikschlosser
force-pushed
the
main
branch
from
b2f8a5c to
67fa57a
Compare
jabolina
requested changes
Sep 26, 2022
There was a problem hiding this comment.
Really nice work! There are a few comments, basically small stuff.
An additional stylistic one that applies to multiple files, but I'll not hold integration for it, is to revert the changes affecting tab width and the line separator. Just to help with the diff, I see that some files only change the line separator, and others have the diff increased because of tab width.
...va/org/infinispan/persistence/cassandra/configuration/CassandraStoreConfigurationParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/infinispan/persistence/cassandra/CassandraStore.java
Outdated
Show resolved
Hide resolved
src/main/java/org/infinispan/persistence/cassandra/CassandraStore.java
Outdated
Show resolved
Hide resolved
src/main/java/org/infinispan/persistence/cassandra/CassandraStore.java
Outdated
Show resolved
Hide resolved
src/main/resources/schema/infinispan-cachestore-cassandra-config-13.0.xsd
Outdated
Show resolved
Hide resolved
src/test/java/org/infinispan/persistence/cassandra/CassandraConfigurationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/infinispan/persistence/cassandra/CassandraStore.java
Outdated
Show resolved
Hide resolved
Co-authored-by: José Augusto Bolina <[email protected]>
dominikschlosser
force-pushed
the
main
branch
from
bde805f to
2da11b3
Compare
dominikschlosser
force-pushed
the
main
branch
from
adc1ab6 to
2e4053d
Compare
|
Merged, thanks for the contribution @dominikschlosser! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tristantarrant We would like to use this store in a project, so i updated the code to the current stable infinispan and cassandra-driver version.