Consolidate entrypoint to support broader deployment scenarios #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
wanpdsantos
force-pushed
the
consolidate-entrypoint
branch
from
4858414 to
a1b79ce
Compare
|
Appreciations! |
…trypoint with flexible flags - Merged the two original scripts (webserver & taskexecutor) into a unified `entrypoint.sh`. - Centralized environment variable replacement in `service_conf.yaml`. - Added CLI flags to enable/disable web server and task executor: - `--disable-webserver` to disable start nginx + `ragflow_server`. - `--disable-taskexecutor` to disable the task executor. - `--host-id` to control unique host ID. - Preserved existing functionality (`LD_LIBRARY_PATH`, `jemalloc`, etc.) and ensured the container remains alive by waiting on background processes.
wanpdsantos
force-pushed
the
consolidate-entrypoint
branch
from
a1b79ce to
143c1ee
Compare
|
@KevinHuSh , updated the PR, now it should work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR gives better control over how we distribute which service will be loaded. With this approach, we can create containers to run only the web server and others to run the task executor. It also introduces the unique ID per task executor host, this will be important when scaling task executors horizontally, considering unique task executor ids will be required.
This new
entrypoint.shmaintains the default behavior of starting the web server and task executor in the same host.Type of change