Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit a more helpful error if INERTIA_LAYOUT is unset #71

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Emit a more helpful error if INERTIA_LAYOUT is unset #71

merged 2 commits into from
Mar 25, 2025

Conversation

akx
Copy link
Contributor

@akx akx commented Mar 14, 2025

The bare attribute error was a bit unhelpful.

BrandonShar
BrandonShar reviewed Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@BrandonShar BrandonShar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change! Is it possible to add a test for this behavior?

@akx akx requested a review from BrandonShar March 17, 2025 07:05
@BrandonShar
Copy link
Collaborator

Thanks @akx !

@BrandonShar
Copy link
Collaborator

BrandonShar commented Mar 25, 2025 •
edited
Loading

dang, I took a shot at reformatting it in the github edit IDE 😄

Don't worry about that, I can fix it when I merge it in. I took some time off work this week so I can pay some more attention to inertia-django!

@BrandonShar BrandonShar merged commit 02d762f into inertiajs:main Mar 25, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonShar BrandonShar BrandonShar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @BrandonShar