Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty p-name for notes #88

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

empty p-name for notes #88

wants to merge 5 commits into from

Conversation

tantek
Copy link
Member

@tantek tantek commented Apr 16, 2020

update docs and examples to suggest empty p-name element for notes and lacking a name, per question in #microformats

@tantek
empty p-name for notes
9a8f261 
update docs and examples to suggest empty p-name element for notes and lacking a name, per question in #microformats
@tantek tantek requested a review from gRegorLove April 16, 2020 01:58
Lewiscowles1986
Lewiscowles1986 approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@Lewiscowles1986 Lewiscowles1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why some characters are escaped and others are not, but it certainly communicates clearly. I've issued suggestions, but I don't think they are blocking because they are unbalanced, so don't form a tag.

templates/validate-h-entry.html.php Outdated Show resolved Hide resolved
templates/validate-h-entry.html.php Outdated Show resolved Hide resolved
templates/validate-h-entry.html.php Outdated Show resolved Hide resolved
@gRegorLove
Copy link
Member

I think all the in-production parsers handle the spec update that reduces instances of implied p-name, so I'm not sure this is a needed recommendation. chat log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prtksxna prtksxna prtksxna approved these changes

@Lewiscowles1986 Lewiscowles1986 Lewiscowles1986 approved these changes

@gRegorLove gRegorLove Awaiting requested review from gRegorLove

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tantek @gRegorLove @prtksxna @Lewiscowles1986