rune/libenclave: preliminary design of libenclave API #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustliyilin
reviewed
Dec 9, 2020
jiazhang0
requested changes
Dec 10, 2020
| bool isRA = 2; | ||
| string spid = 3; | ||
| string subscriptionKey = 4; | ||
| string quoteType = 5; |
There was a problem hiding this comment.
I think we need a ra type parameter instead of the details. Spid, subkey and quoteType all are specific to EPID remote attestation for SGX.
uudiin
added
documentation
uudiin
force-pushed
the
libenclaveapi
branch
from
d5fb364
to
d11e6f9
Compare
I will add .pb.go file until the final version |
jiazhang0
requested changes
Dec 10, 2020
| string stdout = 4; | ||
| string stderr = 5; | ||
| /* Only for vm-based enclave, cpus, memory, kernel, vsock */ | ||
| optional map<string, string> vmconfigs = 6; |
There was a problem hiding this comment.
This mapping is for various enclave type, so it is required to add a string enclaveType parameter to determine the exact format of map.
|
|
||
| message AttestRequest { | ||
| string id = 1; | ||
| bool isRA = 2; |
| string id = 1; | ||
| bool isRA = 2; | ||
| oneof args { | ||
| message la { |
| string subscriptionKey = 4; | ||
| string quoteType = 5; | ||
| } | ||
| message ra { |
There was a problem hiding this comment.
Rename to Rename to sgx_la
haosanzi
added
testing-before-checkin
Signed-off-by: Tianjia Zhang <[email protected]>
Design and implement the new libenclave API. Based on the libenclave API to realize the vm-based enclave type, mainly through compatibility with libvirt. Fixes: inclavare-containers#381 Signed-off-by: Tianjia Zhang <[email protected]>
uudiin
force-pushed
the
libenclaveapi
branch
from
d11e6f9
to
6f8c8c2
Compare
hustliyilin
added
testing-before-checkin
hustliyilin
reviewed
Dec 18, 2020
jiazhang0
added
epic
jiazhang0
requested review from
hustliyilin
and removed request for
jiazhang0 and
hustliyilin
hustliyilin
reviewed
Dec 28, 2020
| } | ||
|
|
||
| func (rt *EnclaveRuntimeWrapper) LaunchAttestation(isRA bool, spid string, subscriptionKey string, quoteType uint32) ([]byte, error) { | ||
| logrus.Debugf("attesting enclave runtime") | ||
|
|
||
| return rt.runtime.Attest(isRA, spid, subscriptionKey, quoteType) | ||
| return nil, rt.runtime.Attest(rt.enclaveId /*, isRA, spid, subscriptionKey, quoteType*/) |
There was a problem hiding this comment.
change to return nil, rt.runtime.Attest(rt.enclaveId, isRA, spid, subscriptionKey, quoteType)
jiazhang0
force-pushed
the
master
branch
3 times, most recently
from
f8ef511
to
6fe93a2
Compare
jiazhang0
force-pushed
the
master
branch
4 times, most recently
from
dc7eb97
to
1cd8c12
Compare
jiazhang0
removed
medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a general Enclave container service, inclavare-containers needs to
support various Enclave forms implemented by software and hardware. It
is necessary to abstract a set of API interfaces that support various
Enclave forms as much as possible.
Fixes: #381
Signed-off-by: Tianjia Zhang [email protected]