INCEpTION HelmChart #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the chart from inception forked repo
kzgrzendek
changed the title
|
TODO :
|
- Changed directory structure to match the HelmChart Release github action.
- Added github action to release the chart to the gh-page branch.
- Added the feat/helmchart branch to the github release action to test the chart release.
- Init the chart with the correspnding github action
- Added anotation to keep the Data PVC resource after deletion of the release.
- Bumped Chart version to 1.0.0 alpha2
- Used out-of-box Bitnami env vars to set MariaDB character set and collation, rather than overriding the config file
- Bumped Chart version to 1.0.0 alpha3
- Bumped Chart version to 1.0.0 alpha3
- Added support for oauth2 role mapping feature and existing pvc for the data volume
- Fixed existing data PVC handling
- Fixed existing data PVC handling
- Added support for secrets for the OAuth2 Client ID
- Added support for secret with clientID
- Fixed bad ref to secretKey for database password in INCEpTION's deployment config
- Updated MariaDB Chart's version
- Split jobs between files - Added dependencies between jobs - Fixed linting job version
- Updated chart formatting and added maintainers
- Updated chart formatting and added maintainers
Updated github workflow organization
Implemented helm-docs action
Fixed bad checkut action version
added 3 commits
October 11, 2024 16:44
Updtaed checkout axction ti v4 and fixed chart location
Updtaed checkout axction to v4 and fixed chart location
Added Helm Chart values schema update
reckart
reviewed
Nov 27, 2024
| fsGroup: 2000 | ||
| # -- Allowing container(s) to run as root. | ||
| # @section -- INCEpTION deployment settings | ||
| runAsNonRoot: true |
There was a problem hiding this comment.
Is it necessary to set that? I believe INCEpTION should be able to run on Kubernetes as a non-privileged user.
| failureThreshold: 5 | ||
|
|
||
| # INCEpTION's pod liveness probe. | ||
| livenessProbe: |
There was a problem hiding this comment.
INCEpTION has an actuator endpoint that can be queried whether the system is ready. Should that be used here?
| @@ -0,0 +1,495 @@ | |||
| # Default values for inception. | |||
There was a problem hiding this comment.
Is there tooling to somehow automatically generate/update this file based on e.g. some Spring metadata?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation
chart/inception/README.mdfilevalues-schema plugin, from the root of the git repo :PS @reckart : The CLAs are on their way, the holidays are adding a bit of delay. I think it's best not merging this MR until you have them, but I'll happily exchange about the feature until then :)