[FEATURE] Add morestep fieldset validation #1090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to validate those fields in multistepform for example
* if the data-powermail-morestep-validate attribute is set to "true" on morestep button (new option) * we validate the visible fields and scroll to the first error in error case
* without it's problamtic if the fieldsets differ in height * if true, the user has to scroll manually to input the new fieldset
* scroll on navigation click, not on btn-group link above
|
The release of feature/visible-field-validation looks good. But unfortunately the form.min.js does not contain the Javascript adjustments. |
|
The |
|
I updated the PR to the latest commit ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the option to validate the current (visible) fieldset on multistep forms.
The validation is done clientsided in JavaScript on page switch and scrolls to the first visible error if exist.
To simplify the usage, the setting validation.morestep.fieldset was added.
As a nice to have improvement, a simple scroll into view for multistep forms on page switch was added, to avoid manual user scrolling if the height of the fieldsets differ.