test: improve test coverage across multiple packages #571
+2,697
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for witness-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Added comprehensive tests for options package (0% → 76.9%) - Added tests for internal/archivista package (0% → 100%) - Enhanced cmd package test coverage (33.3% → 75.8%) - Modified root.go to allow for testing the Execute function - Added tests for previously untested functions - Implemented mock patterns for external dependencies - Used table-driven tests for comprehensive test cases Overall project coverage improved from 24.5% to 66.1% (+41.6%) Signed-off-by: Cole Kennedy <[email protected]>
colek42
force-pushed
the
improve-test-coverage
branch
from
a66a8c5 to
b24ef15
Compare
added 3 commits
March 21, 2025 16:38
Fixed errcheck linting errors by properly checking return values for: - io.Copy calls in test files - flags.Set calls - RunE calls These fixes ensure all test code properly handles potential errors. Signed-off-by: Cole Kennedy <[email protected]>
Signed-off-by: Cole Kennedy <[email protected]>
Fix TestVerifyCmdDeprecatedFlag to ignore error return value from RunE since the command is expected to fail with a specific error message that isn't the focus of the test. Signed-off-by: Cole Kennedy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR significantly improves test coverage across the codebase:
Test Approach
Changes