Skip to content

api/bilibili: support download episode in collection #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

charles7668
Copy link

Previously, Cobalt only downloaded the first video in a Bilibili collection.
This PR adds the ability to download different episodes from the collection.

Copy link
Member

@wukko wukko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the pr! there are some changes that have to be made before we can merge this. you can just commit my suggestions.

i'd also make sure that the episode id is not a random string but is indeed an episode number. would also be nice to add episode tests to util/tests/bilibili.json

@charles7668
Copy link
Author

thank you for the pr! there are some changes that have to be made before we can merge this. you can just commit my suggestions.

i'd also make sure that the episode id is not a random string but is indeed an episode number. would also be nice to add episode tests to util/tests/bilibili.json

If p is a random string, it will download the first episode. In bilibili.json, every p will be marked as successfully downloaded (even if p doesn't exist, it still downloads the first episode).
How can I add a test for this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants