-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
api/bilibili: support download episode in collection #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the pr! there are some changes that have to be made before we can merge this. you can just commit my suggestions.
i'd also make sure that the episode id is not a random string but is indeed an episode number. would also be nice to add episode tests to util/tests/bilibili.json
Co-authored-by: wukko <[email protected]>
Co-authored-by: wukko <[email protected]>
Co-authored-by: wukko <[email protected]>
Co-authored-by: wukko <[email protected]>
Co-authored-by: wukko <[email protected]>
If |
Previously, Cobalt only downloaded the first video in a Bilibili collection.
This PR adds the ability to download different episodes from the collection.