Skip to content

Conversation

@acsauk
Copy link
Contributor

@acsauk acsauk commented Aug 21, 2025

Hey @outofcoffee - thanks for the config pointers, that fixed the issue I was seeing. However, I ran into another problem as some of our mocks rely on external references for component schemas, which, after some digging, I could see wasn't supported.

I've made as minimal a change as possible, not being too familiar with this codebase, so let me know of any changes you want. I also wasn't too sure at what level to test this at, the parser level seemed appropriate but again happy to make changes if you want this further up the stack.

@outofcoffee outofcoffee self-requested a review August 22, 2025 15:20
@outofcoffee outofcoffee self-assigned this Aug 22, 2025
@outofcoffee outofcoffee added the enhancement New feature or request label Aug 22, 2025
@outofcoffee
Copy link
Contributor

Thank you very much for this @acsauk. You've also prompted us to update the config schemas to bring them into alignment with the current data model.

This change looks good - how would you feel about us moving the new property under the plugin-specific config key, e.g.

plugin: openapi
specFile: users-external-ref.yaml

config:
  externalBaseURL: http://example.com

resources:
  - path: /users
    method: GET
    response:
      statusCode: 200

We're considering this as the place for plugin-specific configuration, so, eventually, things like specFile would move there too, albeit with backwards compatibility for existing files.

@acsauk
Copy link
Contributor Author

acsauk commented Sep 12, 2025

Hi @outofcoffee apols for the delay, I'm just back from annual leave.

The config key is a good call - I'll push an update to the PR later today 👍

@acsauk acsauk force-pushed the support-openapi-external-refs branch 2 times, most recently from 60990b1 to 77bb32e Compare September 15, 2025 10:02
@acsauk
Copy link
Contributor Author

acsauk commented Sep 23, 2025

Hi @outofcoffee is there anything else you need changing for this?

Copy link
Contributor

@outofcoffee outofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this feature. Docs will be updated shortly after this is merged.

@outofcoffee outofcoffee force-pushed the support-openapi-external-refs branch from ce8f6bd to 819f13a Compare October 12, 2025 19:00
@outofcoffee outofcoffee changed the title Allow external $refs feat(openapi): allow external $refs Oct 12, 2025
@outofcoffee outofcoffee merged commit 930d7c5 into imposter-project:main Oct 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants