Add schemas for model configs #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesturner246
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JSON schemas for both static and dynamic model configuration files. I've used the files in
healthgps-examplesas a reference, which means that the schemas are currently slightly out of step with the model parsing code in HealthGPS (see #521). I don't intend to enforce these schemas for now though -- I just want them as a reference for when we make a release forhealthgps-examples. Once we've done that, I'll start on some v2 schemas that we can actually enforce (though I'll probably still need some example config files to work from).All the config files in
healthgps-examplesvalidate successfully with these schemas 🥳.There is one small unrelated fix: I noticed that the schema for the
index.jsonfile doesn't allow the user to omit the random seed (which they can do by providing an empty array: #487) so I've changed that.Closes #450. Closes #451.