Add some basic VS Code settings #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesturner246
approved these changes
Aug 16, 2024
Comment on lines
+10
to
+18
| "[json]": { | ||
| "editor.formatOnSave": false | ||
| }, | ||
| "[jsonc]": { | ||
| "editor.formatOnSave": false | ||
| }, | ||
| "[yaml]": { | ||
| "editor.formatOnSave": false | ||
| } |
There was a problem hiding this comment.
Home come the config file rules are disabled?
There was a problem hiding this comment.
You mean for formatOnSave? It's because we don't want VS Code to auto-format these files using its own rules, only to have them be reformatted again by the pre-commit hook on commit. It doesn't really matter, but it's probably a bit annoying to have them fighting each other all the time.
alexdewar
force-pushed
the
vscode_settings
branch
from
bfa5bb1
to
7e31b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It periodically annoys me when I find that files aren't being autoformatted in VS Code or the rulers are in the wrong place for HGPS. Let's add these settings for VS Code users.
I've also added the C++ extension pack (which includes CMake support) and a spellchecker to the extension recommendations.