create_intervention_scenario: std::move risk_impacts to avoid copying #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdewar
force-pushed
the
move_risk_impacts
branch
from
cd6d813
to
c9ab7c3
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| PolicyDynamic dynamic) | ||
| : active_period{period}, impacts{sorted_impacts}, dynamic{std::move(dynamic)} {} | ||
| std::vector<PolicyImpact> sorted_impacts, PolicyDynamic dynamic) | ||
| : active_period{period}, impacts{std::move(sorted_impacts)}, dynamic{std::move(dynamic)} {} |
There was a problem hiding this comment.
warning: std::move of the variable 'dynamic' of the trivially-copyable type 'PolicyDynamic' has no effect; remove std::move() [performance-move-const-arg]
Suggested change
| : active_period{period}, impacts{std::move(sorted_impacts)}, dynamic{std::move(dynamic)} {} | |
| : active_period{period}, impacts{std::move(sorted_impacts)}, dynamic{dynamic} {} |
| PolicyDynamic dynamic) | ||
| : active_period{period}, impacts{sorted_impacts}, dynamic{std::move(dynamic)} {} | ||
| std::vector<PolicyImpact> sorted_impacts, PolicyDynamic dynamic) | ||
| : active_period{period}, impacts{std::move(sorted_impacts)}, dynamic{std::move(dynamic)} {} |
There was a problem hiding this comment.
warning: std::move of the variable 'dynamic' of the trivially-copyable type 'PolicyDynamic' has no effect; remove std::move() [performance-move-const-arg]
Suggested change
| : active_period{period}, impacts{std::move(sorted_impacts)}, dynamic{std::move(dynamic)} {} | |
| : active_period{period}, impacts{std::move(sorted_impacts)}, dynamic{dynamic} {} |
jamesturner246
approved these changes
Aug 12, 2024
alexdewar
force-pushed
the
move_risk_impacts
branch
from
2d23649
to
35919e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was mucking about in the code base, I noticed that we were missing an opportunity to
std::movesomething increate_intervention_scenario(), so I've fixed it up.