Fix: Throw error if invalid model specified (+ refactor) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalonsoa
approved these changes
Jul 14, 2023
Merged
jamesturner246
requested changes
Jul 17, 2023
jamesturner246
approved these changes
Jul 17, 2023
Co-authored-by: James Paul Turner <[email protected]>
Co-authored-by: James Paul Turner <[email protected]>
alexdewar
force-pushed
the
refactor_model_loading
branch
from
a05182d
to
1a6c692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with
clang-tidyas part of my work on #89 and it flagged a problem inmodel_parser.cpp. The issue is that if the JSON file contains an invalid model name, although an error message is printed, the code doesn't abort and will happily register anullptrmodel definition in the cache.I think part of the problem is that the
register_risk_factor_model_definitionsis rather long and with a lot of different branches in it, so it's easy to lose track of what the code is doing. I've split up the model loading into a series of separate functions with appropriate error handling in each.