Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on clippy in CI #594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Turn on clippy in CI #594

wants to merge 3 commits into from

Conversation

kkysen
Copy link
Contributor

@kkysen kkysen commented Aug 9, 2022

Fixes #477.

@kkysen kkysen requested a review from fw-immunant August 9, 2022 22:34
@kkysen kkysen mentioned this pull request Aug 12, 2022
14 tasks
@aneksteind
Copy link
Contributor

I'm conflicted about having this without also having pre-commit hooks, to avoid only finding out about clippy failures during CI, but I think those two together might be overkill at this stage of the project. So, I think that we should instead have only have commit hooks that the developer may selectively ignore locally rather than make continual exceptions for in CI.

@kkysen
Copy link
Contributor Author

kkysen commented Aug 24, 2022

How do pre-commit hooks work? I would like to use those, especially for cargo fmt.

@aneksteind
Copy link
Contributor

https://pre-commit.com/

@kkysen
Copy link
Contributor Author

kkysen commented Aug 24, 2022

https://pre-commit.com/

I'll look into them more, but that seems to be Python-specific pre-commit hooks.

Can pre-commit hooks be pushed to the repo and by default have everyone use them?

@aneksteind
Copy link
Contributor

I'll look into them more, but that seems to be Python-specific pre-commit hooks.

Yep, this is just to demonstrate the concept. I'm sure an equivalent for our purposes can be found.

Can pre-commit hooks be pushed to the repo and by default have everyone use them?

That's been my experience in the past, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch more compile-time errors in CI
2 participants