Skip to content

fix(web): timeline date group width #19964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ben-basten
Copy link
Collaborator

@ben-basten ben-basten commented Jul 16, 2025

Description

Fix the calculation for the date group width, so there's never a scenario where photos will be hidden. Only use photos in the first row of the day group to determine its visible width.

On mobile devices, photos in the second row could have a top position of <100px, which was throwing off the calculation of the date group width.

How Has This Been Tested?

Annotated screenshot

Screenshot 2025-07-16 at 07 10 50

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Copy link
Contributor

Deploying preview environment to https://pr-19964.preview.internal.immich.cloud/

@ben-basten ben-basten marked this pull request as ready for review July 16, 2025 11:28
@ben-basten ben-basten requested a review from midzelis July 16, 2025 11:28
Fix the calculation for the date group width, so there's never a scenario where photos will be hidden. On mobile devices, photos in the second row can sometimes have a top of <100px, which throws off the calculation of the date group width.
@ben-basten ben-basten force-pushed the fix/timeline-missing-photos branch from c264696 to 6d99560 Compare July 16, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Photos missing in timeline on mobile devices Web: timeline doesn't show random assets in date groups at specific browser widths
1 participant