Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Active Layer Transfer Tests #181

Open
gselzer opened this issue Mar 8, 2023 · 2 comments
Open

Re-enable Active Layer Transfer Tests #181

gselzer opened this issue Mar 8, 2023 · 2 comments
Assignees
Labels
blocked Waiting for an upstream change bug Something isn't working
Milestone

Comments

@gselzer
Copy link
Collaborator

gselzer commented Mar 8, 2023

imagej-legacy seems to modify the behavior of Display.close(), likely through DisplayDeletedEvent, and I've put a great deal of effort without results into trying to get Display.close() to actually remove the display from DisplayService.getDisplays(). So, for now, since I know it works in practice, I'm disabling these tests in #151 when ImageJ Legacy is enabled.

But we should re-enable them once Display.close() is fixed, which will require upstream changes/releases.

@gselzer gselzer added bug Something isn't working blocked Waiting for an upstream change labels Mar 8, 2023
@gselzer gselzer added this to the 1.0.0 milestone Mar 8, 2023
@gselzer gselzer self-assigned this Mar 8, 2023
@ctrueden
Copy link
Member

ctrueden commented May 4, 2023

@gselzer Is this intended for 0.1.0, or 1.0.0? Right now it is in the former's project column, but the latter's milestone.

Also, what exactly needs to be done, in which upstream component(s)?

@gselzer
Copy link
Collaborator Author

gselzer commented May 5, 2023

@ctrueden it's intended for 1.0.0/never.

Looking at my initial comment, it looks like we need a fix in imagej-legacy. I don't remember what I was trying earlier...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting for an upstream change bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants