Onion Architecture #3266
Open
Onion Architecture #3266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR SummaryThis PR implements the Onion Architecture pattern in a Java application. The application manages a TODO list, demonstrating the architecture's layered structure with separation of concerns. The core domain logic is independent of infrastructure concerns, promoting testability and maintainability. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- d91d3d8: Onion Architecture
Files Processed (8)
- onion-architecture/README.md (1 hunk)
- onion-architecture/src/main/Main.java (1 hunk)
- onion-architecture/src/main/application/TodoService.java (1 hunk)
- onion-architecture/src/main/domain/TodoItem.java (1 hunk)
- onion-architecture/src/main/domain/TodoRepository.java (1 hunk)
- onion-architecture/src/main/infrastructure/TodoRepositoryImpl.java (1 hunk)
- onion-architecture/src/test/application/TodoServiceTest.java (1 hunk)
- onion-architecture/src/test/domain/TodoItemTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
iluwatar
requested changes
Apr 27, 2025
| import infrastructure.TodoRepositoryImpl; | ||
|
|
||
| import java.util.Scanner; | ||
|
|
There was a problem hiding this comment.
Here above the Main, explain the pattern and describe how this code example implements it.
| Scanner scanner = new Scanner(System.in); | ||
| TodoService service = new TodoService(new TodoRepositoryImpl()); | ||
|
|
||
| System.out.println("Welcome to the TODO App!"); |
There was a problem hiding this comment.
Use Lombok's @slf4j logging utility
Comment on lines
+8
to
+12
| public TodoItem(int id, String title) { | ||
| this.id = id; | ||
| this.title = title; | ||
| this.isCompleted = false; | ||
| } |
There was a problem hiding this comment.
You can use Lombok's @AllArgsConstructor
Comment on lines
+9
to
+31
| public class TodoServiceTest { | ||
| public static void main(String[] args) { | ||
| TodoRepositoryImpl fakeRepo = new TodoRepositoryImpl(); | ||
| TodoService service = new TodoService(fakeRepo); | ||
|
|
||
| service.createTodo("Learn onion architecture"); | ||
| service.createTodo("Write unit tests"); | ||
|
|
||
| List<TodoItem> todos = service.getTodos(); | ||
|
|
||
| assert todos.size() == 2 : "Should have 2 todos"; | ||
| assert todos.get(0).getTitle().equals("Learn onion architecture"); | ||
| assert !todos.get(0).isCompleted(); | ||
|
|
||
| int idToComplete = todos.get(0).getId(); | ||
| service.completeTodo(idToComplete); | ||
|
|
||
| todos = service.getTodos(); | ||
| assert todos.get(0).isCompleted() : "First item should be completed"; | ||
|
|
||
| System.out.println("TodoServiceTest passed"); | ||
| } | ||
| } |
There was a problem hiding this comment.
It doesn't look like a valid JUnit test. You should mark it with @test annotation.
Comment on lines
+5
to
+19
| public class TodoItemTest { | ||
| public static void main(String[] args) { | ||
| TodoItem item = new TodoItem(1, "Write tests"); | ||
|
|
||
| assert item.getId() == 1 : "ID should be 1"; | ||
| assert item.getTitle().equals("Write tests") : "Title should match"; | ||
| assert !item.isCompleted() : "Item should not be completed initially"; | ||
|
|
||
| item.markCompleted(); | ||
|
|
||
| assert item.isCompleted() : "Item should be marked as completed"; | ||
|
|
||
| System.out.println("TodoItemTest passed"); | ||
| } | ||
| } |
| System.out.println("\nWhat would you like to do?"); | ||
| System.out.println("[a] Add tasks"); | ||
| System.out.println("[d] Mark tasks as done"); | ||
| System.out.println("[v] View tasks"); |
There was a problem hiding this comment.
Maybe add "delete task" function as well?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?