Refactored changes for seperated-interface #2881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to contain changes for several patterns. Could you make a separe PR for each? |
iluwatar
requested changes
Apr 1, 2024
|
hey @drishtii7, The code style does not follow the google style that project use. See: https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions You can run the checkstyle checks using IDE plugin or using the command line (mvn validate). |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For the method getTaxPercentage introduced in the DomesticTaxCalculator and ForeignTaxCalculator classes, and it's common to both classes. I have pull this method up to a superclass named AbstractTaxCalculator.