Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(microservices-self-registration): completed discovery server and… #2779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(microservices-self-registration): completed discovery server and… #2779

wants to merge 1 commit into from

Conversation

Pat-r1ck
Copy link

Microservices Self Registration #2687

  • Microservice structure contains discovery-server & client service
  • During startup, client service would register itself with the discovery-server
  • During crash, client service would unregister itself from the discovery-server

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stale Stale
Copy link

stale bot commented Dec 28, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Dec 28, 2023
@Pat-r1ck
Copy link
Author

@iluwatar please review my pull request, thank you

@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Jan 29, 2024
@stale Stale
Copy link

stale bot commented Feb 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Feb 28, 2024
iluwatar
iluwatar requested changes Mar 10, 2024
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, please add this module to the parent pom.xml. Otherwise it's not built by CI.

microservices-self-registration/client-service/pom.xml
Comment on lines +14 to +18
<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, these come from parent pom.xml

...tration/client-service/src/main/java/com/patrick/clientservice/ClientServiceApplication.java

@EnableDiscoveryClient
@SpringBootApplication
public class ClientServiceApplication
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add JavaDoc to explaing the purpose of this class and its role in the pattern

microservices-self-registration/discovery-server/pom.xml
Comment on lines +14 to +18
<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

...n/discovery-server/src/main/java/com/patrick/discoveryserver/DiscoveryServerApplication.java

@EnableEurekaServer
@SpringBootApplication
public class DiscoveryServerApplication
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add JavaDoc to explaing the purpose of this class and its role in the pattern

@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Mar 10, 2024
@stale Stale
Copy link

stale bot commented Apr 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pat-r1ck @iluwatar