Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add Monolithic Architecture pattern (#2664) #2760

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

nuxchristopher
Copy link

@nuxchristopher nuxchristopher commented Oct 29, 2023

Monolithic Architecture pattern (#2664)

Pull request description

  • sample java code with javadoc
  • test code
  • UML diagram
  • README.md file

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 46 Code Smells

69.8% 69.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

stale bot commented Nov 29, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Nov 29, 2023
Copy link

stale bot commented Jan 13, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Jan 13, 2024
@iluwatar iluwatar reopened this Feb 25, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Feb 25, 2024
@@ -0,0 +1,167 @@
---

title: Exploring the Monolithic Architecture in E-commerce
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest just 'Monolithic Architecture'

@@ -0,0 +1,42 @@
@startuml
interface com.iluwater.monolithic.architecture.ICustomerService {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR too, please update to com.iluwatar :)

Comment on lines +14 to +18
<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be left out since they come from the parent pom.xml

Comment on lines +6 to +18
/**
* The main application class providing a command-line interface to interact
* with customer and order modules.
* <p>
* The application provides menu-driven options to the user for performing various
* operations like fetching customer details by ID, updating credit limits,
* creating new customers, making orders, and fetching order totals for a given customer.
* </p>
* <p>
* The underlying data operations are performed through {@link CustomerModuleInterface} and
* {@link OrderModuleInterface} implementations.
* </p>
*/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the monolithic architecture pattern briefly and the explain how this example implements it

try {
switch (choice) {
case "1":
System.out.print("Enter Customer ID: ");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use proper logger. Use the one that Lombok provides.

Copy link

sonarcloud bot commented Feb 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link

stale bot commented Mar 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Mar 26, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Mar 27, 2024
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.8% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

stale bot commented Apr 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants