Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished the Microservice Architecture #2759

Closed
wants to merge 8 commits into from

Conversation

OscarXWei
Copy link

Finished the Microservice Architecture

Pull request description

  • I finish this issue: #2665

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

@JaimeChavarriaga
Copy link

I think that the automated build is failing because:

  • The checkstyle plugin is configured with 2-spaces indentation but the code uses 4-spaces.
  • There are several classes without javadoc comments.
  • There is one import * instead of multiple import of specific classes

You may run mvn checkstyle:check to get a list of issues to solve.
In addition, the class CustomeService may be renamed to CustomerService.

Copy link

stale bot commented Nov 30, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Nov 30, 2023
Copy link

stale bot commented Jan 14, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Jan 14, 2024
@iluwatar iluwatar reopened this Feb 25, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Feb 25, 2024
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things before merge, looks good!

Comment on lines +14 to +18
<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines not needed, they come from the parent

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, above the main class, we need to describe the pattern and explain how the code implement it

import org.springframework.stereotype.Service;

@Service
public class ConsumeService {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be ConsumerService ?

Copy link

stale bot commented Mar 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Mar 26, 2024
Copy link

stale bot commented May 11, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this May 11, 2024
@iluwatar iluwatar reopened this May 12, 2024
@iluwatar iluwatar closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants